fix(assert): remove runtime assert that could crash production builds

use debug only assert to remove the possibility that we self inflict
crashes on users

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8199 from nextcloud/backport/8193/stable-3.16

[stable-3.16] Bugfix/do not crash when propagating changes with move or rename

fix(rename): avoid hitting runtime assert when renaming virtual files

when propagating a rename to the child items, we must not make child
items be done from propagator point of view

they will be part of their own propagator item and that will create
issues

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(rename): handle complex rename/move scenario

ensure we do not leak records and properly update them in client
database

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat(discovery): add more info for renamed items

add original name
add renamed name
add target name

should make it easier to analyze rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat(discovery): add missing inode info for discovered files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

perf(discovery): optimize empty strings

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8198 from nextcloud/backport/8195/stable-3.16

[stable-3.16] revert to QFile::remove to remove single files

fix(filesystem): warn when trying to delete an already deleted file

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(filesystem): still use std::filesystem::remove for folders

this API has a way to provide an error when failing to delete a folder

we may want to know why teh folderf ailed to be deleted

QDir::rmdir does not provide any error when failing to delete a folder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix: Revert "stop using QFile api to delete a single local file"

This reverts commit 58d28ab3306a5cd36d990678416375386d9a0db9.

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8196 from nextcloud/backport/8182/stable-3.16

[stable-3.16] Bugfix/read only windows folders

fix(rmdir): switch to another API for folder removal

current QDir::rmdir API does not provide an error message when failing
to delete

retuse FileSystem::remove that may just works with folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(autotests): do not remove read-only files already removed

the sync engine will remove invalid items inside read-only folders

not needed to remove them in tests and rather checks that they were
indeed removed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

refactor(logs): improve logs around deletions and permissions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(permissions): solve issues with file permissions automated tests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix(read only folder): allow renaming new file inside read-only folders

needed to download a new file inside a read-only folder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat(windows native API): use windows specific API for read-only folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8197 from nextcloud/backport/8189/stable-3.16

[stable-3.16] Bugfix/filesystem remove file not working

fix: use safer conversion from QString to filesystem::path

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

feat: better logs when a file cannot be removed

should log the reason why a file cannot be deleted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8194 from nextcloud/backport/8190/stable-3.16

[stable-3.16] pin Craft revision to a specific commit

ci: pin craft revision to a specific commit

25.03-nc still has pkg-config in it, which recently got replaced in
Craft by pkgconf

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

ci: temporarily use custom craftmaster fork

this is required to make `General`.`CraftRevision` work as intended.

Revert this after
https://invent.kde.org/packaging/craftmaster/-/merge_requests/7 is
merged.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

build: prepare 3.16.3 release.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #8172 from nextcloud/backport/8168/stable-3.16

[stable-3.16] use specific revision for KDE blueprints that matches the craft cache

ci: use specific revision for KDE blueprints that matches the craft cache

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8169 from nextcloud/backport/8036/stable-3.16

[stable-3.16]  fix(migration): import proxy and general settings from legacy config.

fix: non-void function does not return a value in all control paths.

Signed-off-by: Camila Ayres <hello@camilasan.com>

fix: remove unused var.

Signed-off-by: Camila Ayres <hello@camilasan.com>

chore: make settings keys const static member of ConfigFile class.

Signed-off-by: Camila Ayres <hello@camilasan.com>

chore: rename function, change log level.

Signed-off-by: Camila Ayres <hello@camilasan.com>

fix(migration): import proxy and general settings from legacy config.

Signed-off-by: Camila Ayres <hello@camilasan.com>

chore(migration): remove duplicated code when copying legacy config to new path.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #8166 from nextcloud/backport/8160/stable-3.16

[stable-3.16] fix(msi): allow custom installation directory

fix(msi): allow custom installation directory

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8162 from nextcloud/backport/8156/stable-3.16

[stable-3.16] fix(theme): correct dark/light mode check on Win10

fix(theme): correct dark/light mode check on Win10

`Utility::registryGetKeyValue` returns an invalid QVariant should the
key not exist -- which is the case if that switch has never been toggled
before.

--> Fix this by ensuring the QVariant is valid, and only then try to
convert it to a bool.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8159 from nextcloud/backport/5543/stable-3.16

[stable-3.16] Use AccountPtr in Account signals instead of raw pointer

fix(gui): Use AccountPtr in setup wizard

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix use of saveAccount in networksettings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use AccountPtr in testpushnotifications

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use AccountPtr in serverVersionChanged signal instead of raw pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Replace use of raw pointer in wantsAccountSaved signal with AccountPtr

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Emit AccountPtr from pushNotificationsDisabled in Account rather than raw pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use AccountPtr in pushNotificationsReady signal in Account rather than raw pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #8158 from nextcloud/backport/5288/stable-3.16

[stable-3.16] Exclude NavigationPaneHelper from non-Windows compile

Only build NavigationPaneHelper on Windows

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Ifdef all mentions of navigationpanehelper out of non-Windows builds

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #8163 from nextcloud/backport/8038/stable-3.16

[stable-3.16] skip single test or whole test file for macOS: they are broken

skip single test or whole test file for macOS: they are broken

would need careful analyze to fix those

until we can get them fixed, better make the other tests be required in
the CI

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8157 from nextcloud/backport/8111/stable-3.16

[stable-3.16] fix(PinState): don't trigger sync when file's PinState changed to Unspecified.

test(cfapi): check for spurious attribute changes.

Signed-off-by: Camila Ayres <hello@camilasan.com>

fix(PinState): don't trigger sync when file's PinState changed to Unspecified.

LibreOffice/Microsoft office might touch the files for unknown reasons,
creating a constant sync state (icon) visible in the parent folder.

This fix excludes PinState changes from a new sync if the trigger
might have been an external application.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8153 from nextcloud/backport/8145/stable-3.16

[stable-3.16] simplify deletions of invalid read-only items: do not interrupt sync

fix: do not interrupt sync when cleaning invalid read-only items

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8141 from nextcloud/backport/8140/stable-3.16

[stable-3.16] disable use of bulk upload for small files

disable use of bulk upload for small files

this feature causes many issues with impact on users so we prefer to
disable it again

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8139 from nextcloud/backport/8048/stable-3.16

[stable-3.16] Bugfix/slow bulk upload

simple way to add more logs related to upload progress

will be important to try to see upload performance bottlenecks

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

clean up some no longer needed logs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

better logs to track sending of data during bulk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

clean code and logs during bulk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

no need to disable buffering from Qt in POST requests

data of the files are ready in a memory buffer so Qt will not buffer
them anyway

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

use maximum chunk size to decide the size of a bulk upload request

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

remove useless log

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

define content length header with bulk upload requests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

use memory to buffer the data of the files sent during bulk upload

should help make it faster to send all data

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

disable buffering when POSTing for bulk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Add test for syncing with bulk upload when there are errors.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Change bulk upload batch size when there is a sync error.

- Cancel sync after try with smaller bulk upload batch size also throws error.
- Continue syncing when there is no error.
- Remove file from bulk upload black list only when upload succeeded.

Signed-off-by: Camila <hello@camila.codes>

Merge pull request #8137 from nextcloud/backport/8094/stable-3.16

[stable-3.16] Bugfix/use newer bulk upload checksum header

only send the md5 custom checksum header when server expects it

server before 32.0.0 release expects a custom header with an MD5
checksum during bulk upload

the header name is: X-File-MD5

see https://github.com/nextcloud/server/pull/51729

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

with release 32.0.0 md5 custom checksum is removed from bulkupload

makes our fake server require an md5 custom checksum for bulk upload
until version 32.0.0

starting with 32.0.0 this custom checksum must be empty

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix format of checksum header that was missing checksum type

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

sending header X-File-MD5 that is currently mandatory

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

automated tests of bulk upload needs to check checksums like real

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8131 from nextcloud/backport/8095/stable-3.16

[stable-3.16] fix: try to correct mtime on upsyncs

fix FileSystem::setModTime on x64 Windows with times > 2038

also removes some unused Utility methods

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix: try to correct mtime on upsyncs

Files with a modification time of less than 0 do usually not make sense
(and afaik the server doesn't accept them either).
--> attempt to update the modification time to _Time.now_ while
propagating

side note: I ran into this because KArchive/Ark(?) didn't consider the
extra time attributes on entries for a certain zip file, so it instead
used the standard time value of each zip entry which was set to <= 1980
for files and < 1970 for directories...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8130 from nextcloud/backport/8127/stable-3.16

[stable-3.16] stop using QFile api to delete a single local file